Fix the fetching of images in CF_DIB format in DisplayServerWindows::clipboard_get_image
#88220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:import
platform:windows
topic:porting
and removed
topic:import
labels
AThousandShips
changed the title
bruvzg
approved these changes
Feb 12, 2024
|
Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
akien-mga
changed the title
CF_DIB format in DisplayServerWindows::clipboard_get_image
akien-mga
added
the
cherrypick:4.2
FaycalElOuariachi
force-pushed
the
display_server_windows-clipboard_get_image-fix-DIB-image-import
branch
from
0d9d5f8 to
3b18d71
Compare
|
Thank you for your help. I tried to amend my commit to fix this. Is it correct now ? Must I completely redo the commit ? |
|
Seems good now, it's got two authors though, unsure if it matters, could do |
FaycalElOuariachi
force-pushed
the
display_server_windows-clipboard_get_image-fix-DIB-image-import
branch
from
3b18d71 to
4e990cd
Compare
…clipboard_get_image Fix the fetching of images from windows clipboard, if they're in CF_DIB format (e. g. by taking screenshots). Image::create_from_data was used with an instance of Image, but it's a static function, returning a new instance.
|
The amend was creating a new commit and a merge commit... Unfortunalty to avoid that, I did something bad by force pushing. Sorry for that... (I'll make sure to be cautious next time) |
|
It looks good now! |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was occuring when trying to import an image from the windows clipbpoard, if it's in CF_DIB format (e. g. by taking screenshots). No image was returned.
It comes from a tiny error : in
DisplayServerWindows::clipboard_get_image,Image::create_from_datawas used with an instance ofImage, but since it's a static function, it returns a new instance instead of modifying the 'called' one.Correcting this fixes the importation.
Testing with a GDScript
This script was attached to a TextureRect node in the testing scene.
(At the start, the clipboard must contains an image in CF_DIB format, for instance a screenshot, or some images coming from a web navigator, in the right format, copied with the right-click context menu.)
PS : I apologies if my PR isn't conform to godot contributor's workflow, or for any other problem.